Add missing data to session #1542
Conversation
## Description Fixes (#1540) This adds associated_user_scope and associated_user which is stated in Shopify [documentation](https://shopify.dev/tutorials/authenticate-with-oauth#step-3-confirm-installation). <!-- Please include a summary of what you want to achieve in this pull request. Remember to indicate the affected package(s). --> ## Type of change <!-- If this pull request changes multiple packages, please indicate the type of change for each package. If this is a new package, you may disregard this section. Please delete options that are not relevant. --> - [x] @shopify/koa-shopify-auth Patch: Bug (non-breaking change which fixes an issue)expected) ## Checklist - [x] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)
Inserted `,⏎···` prettier/prettier Deleted `····⏎····` prettier/prettier
|
I need help on prettier/prettier I can not get it to build on travis |
| const {access_token: accessToken, | ||
| associated_user_scope: associatedUserScope, | ||
| associated_user: associatedUser} = accessTokenData; |
There was a problem hiding this comment.
| const {access_token: accessToken, | |
| associated_user_scope: associatedUserScope, | |
| associated_user: associatedUser} = accessTokenData; | |
| const { | |
| access_token: accessToken, | |
| associated_user_scope: associatedUserScope, | |
| associated_user: associatedUser | |
| } = accessTokenData; |
I think prettier is looking for something like this. I am not sure why it is only failing on a single version though.
|
@TheMallen can you take a look and also assist in merging? I am not that familiar with the changelog process. |
|
Thank you for contributing to the ongoing improvement of this library - we really appreciate it. In order to optimize the support on this particular piece of functionality, we have moved it to its own repo. As a result, I’m closing this PR because the underlying source has been moved to a dedicated new repo; If you would like the PR to be considered for review, please re-create the change against the new Thank you! |
Description
Fixes (#1540)
This adds associated_user_scope and associated_user which is stated in Shopify documentation.
Type of change
Checklist